Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak: clear GDK_PIXBUF_MODULE_FILE #59665

Merged
merged 1 commit into from Apr 16, 2019
Merged

flatpak: clear GDK_PIXBUF_MODULE_FILE #59665

merged 1 commit into from Apr 16, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Apr 16, 2019

Motivation for this change

GDK_PIXBUF_MODULE_FILE is often set to a nix store path not available in a app
sandbox. This can cause some apps to fail launching, simply reset this env var
when running applications.

fixes #53441

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
flatpak: clear GDK_PIXBUF_MODULE_FILE
752e176 
GDK_PIXBUF_MODULE_FILE is often set to a nix store path not available in a app
sandbox. This can cause some apps to fail launching, simply reset this env var
when running applications.

fixes NixOS#53441
@jtojnar
Copy link
Contributor

jtojnar commented Apr 16, 2019

Is it still possible to pass it with flatpak run --env=GDK_PIXBUF_MODULE_FILE=XXX?

@hedning
Copy link
Contributor Author

hedning commented Apr 16, 2019

Yeah, the default environment (which resets are a part of) is applied before applying the «app context», which includes command line arguments.

https://github.com/flatpak/flatpak/blob/2bfa0060b089a20de5fbf18d018f8f1b108d2480/common/flatpak-run.c#L3236-L3258

@infinisil infinisil merged commit 91a9000 into NixOS:master Apr 16, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/flatpak-app-authenticator-fails-to-run/2452/3

@hedning hedning deleted the flatpak-fix-pixbuf-leakage branch April 17, 2019 08:22
@matthewbauer
Copy link
Member

Backported to 19.03 in be89fd6.

@jtojnar jtojnar mentioned this pull request Jun 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flatpak: Marker (markdown editor) does not start up
6 participants
@hedning @jtojnar @nixos-discourse @matthewbauer @infinisil @GrahamcOfBorg