make-derivation: put patches in all derivations #59755
Conversation
This puts patches in all derivations even if it unspecified by the
derivation. By default it will be an empty list. This simplifies
overrides, as we can now assume that patches is a valid name so that
this works:
self: super: {
mypkg = super.pkg.overrideAttrs (o: {
patches = o.patches ++ [ ./my-very-own.patch ];
});
}
That is, you don’t need to provide a default "or []", make-derivation
provides one for you.
Unfortunately, this is a mass rebuild.
|
Yes! I would like to do this for all standard variables. It is good preparation for structured attrs too. @matthewbauer could you also go in |
|
There are a few more "standard" flags that often need to be composed. For instance, I would like to put these flags in make-derivation.nix like:
We don't want to go too crazy with this. Things like flags for cmake, meson, etc. may not make sense in make-derivation. |
|
Yes, the more we bake in variables in |
|
👍 This will also prevent Linux rebuilds when adding a Darwin-only patch to an expression without |
This puts patches in all derivations even if it unspecified by the
derivation. By default it will be an empty list. This simplifies
overrides, as we can now assume that patches is a valid name so that
this works:
That is, you don’t need to provide a default "or []", make-derivation
provides one for you.
Unfortunately, this is a mass rebuild.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)