Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphinEmuMaster: 2019-02-16 -> 5.0-9976 #59645

Merged
merged 1 commit into from Apr 18, 2019
Merged

dolphinEmuMaster: 2019-02-16 -> 5.0-9976 #59645

merged 1 commit into from Apr 18, 2019

Conversation

ashkitten
Copy link
Contributor

Motivation for this change

changed versioning scheme to match dolphin's own. this also allows us to include the describe string without deriving it from the git repository during build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ashkitten
dolphinEmuMaster: 2019-02-16 -> 5.0-9976
e9c7966 
changed versioning scheme to match dolphin's own. this also allows us to
include the describe string without deriving it from the git repository
during build.
@GrahamcOfBorg GrahamcOfBorg requested a review from MP2E April 15, 2019 22:34
@aanderse
Copy link
Member

@GrahamcOfBorg build dolphinEmuMaster

aanderse
aanderse approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran locally.
LGTM 👍

@MP2E MP2E merged commit 1e86069 into NixOS:master Apr 18, 2019
@MP2E
Copy link

MP2E commented Apr 18, 2019

Thanks! Looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashkitten @aanderse @MP2E @GrahamcOfBorg