Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-control-center: Add mutter keybindings #59765

Merged
merged 1 commit into from Apr 17, 2019
Merged

gnome3.gnome-control-center: Add mutter keybindings #59765

merged 1 commit into from Apr 17, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 17, 2019 •
edited

Motivation for this change

Closes: #19590

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added this to In Progress in GNOME Apr 17, 2019
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 17, 2019
@hedning
Copy link
Contributor

hedning commented Apr 17, 2019

Does pantheon use gsc? Since it uses an older mutter that could be problem, though the newer schema is probably fine. Otherwise lgtm.

@worldofpeace
Copy link
Contributor

Does pantheon use gsc? Since it uses an older mutter that could be problem, though the newer schema is probably fine.

They have switchboard-plug-keyboard and use similar schemas

Annoying part is that they're plugins so I can't really wrap anything.
Wasn't following this issue though.

worldofpeace
worldofpeace approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things tested

  • Can see all the sections mentioned by jluttine. ✔️
  • Can set and activate shortcuts in Navigation and Windows ✔️

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 17, 2019

Borg fails on grilo-plugins missing libgdata headers but that is an independent failure.

@jtojnar jtojnar merged commit 1bdbe45 into NixOS:master Apr 17, 2019
GNOME automation moved this from In Progress to Done Apr 17, 2019
@jtojnar jtojnar deleted the g-c-c-mutter branch April 17, 2019 19:05
@worldofpeace
Copy link
Contributor

Weird reverting c2de086 makes it build.

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 17, 2019

Yep, debugging now.

@jtojnar jtojnar mentioned this pull request Apr 17, 2019
Closed
@das-g
Copy link
Member

das-g commented Apr 17, 2019

Can this be backported to NixOS 19.03?

(In #19590 (comment), [GNOME(?)] 3.32 was mentioned, while NixOS 19.03 has GNOME 3.30. Is Gnome 3.32 a hard requirement for this fix?)

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 17, 2019

It was only mentioned to avoid conflicts.

@das-g das-g mentioned this pull request Apr 18, 2019
Merged
10 tasks
jtojnar added a commit to jtojnar/nixpkgs that referenced this pull request Jun 14, 2019
@jtojnar
gnome3.gnome-control-center: Add mutter to dependencies
fc4cc85 
NixOS#59765 fixed the keybndings issue NixOS#19590 only partially, we still need to
make the gschemas available.
@jtojnar jtojnar mentioned this pull request Jun 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GNOME keyboard shortcuts settings incomplete
5 participants
@jtojnar @hedning @worldofpeace @das-g @GrahamcOfBorg