Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prl-tools: 12.2.1-41615 -> 14.1.3-45485 #59817

Closed
wants to merge 2 commits into from
Closed

prl-tools: 12.2.1-41615 -> 14.1.3-45485 #59817

wants to merge 2 commits into from

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Apr 18, 2019

cc: @abbradar

Motivation for this change

Update parallels desktop((a virtual machine software on macos) tools version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Vonfry Vonfry changed the title prl-tools: 12.2.1-41615 14.1.3-45485 prl-tools: 12.2.1-41615 -> 14.1.3-45485 Apr 18, 2019
@Vonfry
Copy link
Member Author

Vonfry commented Apr 21, 2019

Could someone review this pr? It seems that @abbradar didn't login in github for some time.

@infinisil
Copy link
Member

Can you split the change for adding yourself as a maintainer into a separate commit (in this same PR)?

I assume you've tested parellels? If so this looks good to merge after the above has been changed.

@Vonfry
Copy link
Member Author

Vonfry commented Apr 23, 2019

Sorry, I find some new problems on this update. I close the pr and fix it.

@Vonfry Vonfry closed this Apr 23, 2019
@Vonfry Vonfry mentioned this pull request Apr 23, 2019
Closed
@Vonfry Vonfry deleted the fix/prl-tools-update branch September 2, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vonfry @infinisil @GrahamcOfBorg