Engraving #394
Merged
Engraving #394
+99
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Apr 16, 2019
src/export.cpp
Outdated
| @@ -92,8 +91,27 @@ void SolveSpaceUI::ExportSectionTo(const Platform::Path &filename) { | |||
| sb->auxA = Style::SOLID_EDGE; | |||
| } | |||
|
|
|||
| el.CullExtraneousEdges(); | |||
| bl.CullIdenticalBeziers(); | |||
| el.CullExtraneousEdges(true); | |||
There was a problem hiding this comment.
Would be good to have /*both=*/ here and elsewhere because it looks quite puzzling otherwise.
whitequark
reviewed
Apr 16, 2019
bcmpinc
commented
Apr 16, 2019
| } | ||
| openContours->l.Add(loop); | ||
| } else { | ||
| loop->Clear(); |
There was a problem hiding this comment.
Here is where the open loops used to be exploded into separate segments.
|
@bcmpinc Thank you for the PR, and sorry for the delay in merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly use solvespace for designing stuff that I then cut out using a laser cutter. For that purpose I always use the section export function. In the past I used Inkscape to add text or line segments, but I would prefer to be able to model these in solvespace, especially when positioning is important.
For custom line styles, there is an option "export these objects", which I hoped meant that these lines are included in the section export, but they aren't. This patch changes that, such that they are included. To get it to work properly I had to change some parts of the code for which I'm not sure whether I got them correct.
I don't know what "export these objects" is supposed to do, so I guess this is not entirely the right place for configuring a style for section export and that a new flag might be more appropriate.
Please let me know what you think of it.
P.S. I thought that it would be useful to add a way to disable the closed contour check for these custom line styles, but this is already possible by turning them into construction line segments (although those are visually indistinguishable).