offsetTop/offsetLeft of inline elements #16375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1570749
branch
from
59550ac
to
1c0e2d5
Compare
- Fix offsetTopLeftInline.html for legacy (because I need the test coverage when working on visual rects). - Add a test for offsetTop/offsetLeft of empty inline elements. The test fails in LayoutNG. Bug: 953479 Change-Id: I31eceb4f22540c49db037f685867c95a33e0390d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570749 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#651520}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1570749
branch
from
1c0e2d5
to
e5f60d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coverage when working on visual rects).
The test fails in LayoutNG.
Bug: 953479
Change-Id: I31eceb4f22540c49db037f685867c95a33e0390d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570749
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651520}