Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: fix darwin sandbox build #59624

Merged
merged 1 commit into from Apr 20, 2019
Merged

libuv: fix darwin sandbox build #59624

merged 1 commit into from Apr 20, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 15, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Apr 15, 2019
matthewbauer
matthewbauer reviewed Apr 15, 2019
View reviewed changes
pkgs/development/libraries/libuv/default.nix
@@ -55,6 +59,9 @@ stdenv.mkDerivation rec {

doCheck = true;

# Some of the tests use localhost networking.
__darwinAllowLocalNetworking = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should make this true globally? This kind of thing works by default on linux in sandboxing iirc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike on linux localhost networking is not isolated by default so I think this is a good thing. I'll probably have to revisit the sandboxing rules at some point so we could remove the option then, but so far this has not been prevalent enough to be necessary IMHO.

@LnL7 LnL7 merged commit cc6b56d into NixOS:staging Apr 20, 2019
@LnL7 LnL7 deleted the darwin-libuv branch April 20, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @matthewbauer @GrahamcOfBorg