Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.tracker: correct gdbus path #59627

Merged
merged 1 commit into from Apr 15, 2019
Merged

gnome3.tracker: correct gdbus path #59627

merged 1 commit into from Apr 15, 2019

Conversation

worldofpeace
Copy link
Contributor

It's in glib.bin

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 15, 2019
hedning
hedning approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtojnar
Copy link
Contributor

jtojnar commented Apr 15, 2019 •
edited

Maybe we might want to substitute gdbus = "${glib.bin}/bin/gdbus" to make the context fixed and obvious.

@worldofpeace
Copy link
Contributor Author

Did that @jtojnar

@worldofpeace worldofpeace merged commit 9e3d9e2 into NixOS:master Apr 15, 2019
@worldofpeace worldofpeace deleted the tracker-correct branch April 15, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @hedning @GrahamcOfBorg