Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 8ac7316db613
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: d0da672b0e03
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 17, 2019

  1. glibc: re-enable stripping in cross builds 

    References to the host toolchain are leaking through debug symbols in
glibc, causing gnu cross-builds to always depend on the host toolchain.
The decision to not strip was made in 2012 in order to improve GNU/Hurd
support, and I suspect the reasons that justified it back then do not
apply anymore in 2019.

Closure size before:
/nix/store/v5pxj0bgg627hic2khk4d43z6cjp5v7d-hello-2.10-armv7l-unknown-linux-gnueabihf                            596.8M

After:
/nix/store/llp1ncmpar406rc2vhj7g5ix4yqwna3n-hello-2.10-armv7l-unknown-linux-gnueabihf     23.6M
    @delroth
    delroth committed Apr 17, 2019
    Copy the full SHA
    03f618d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #59787 from delroth/strip-glibc 

    glibc: re-enable stripping in cross builds
    @matthewbauer
    matthewbauer committed Apr 17, 2019
    Copy the full SHA
    d0da672 View commit details
    Browse the repository at this point in the history