Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.grilo-plugins: add dependencies #59793

Merged
merged 1 commit into from Apr 17, 2019
Merged

gnome3.grilo-plugins: add dependencies #59793

merged 1 commit into from Apr 17, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 17, 2019

Motivation for this change

Add libsoup dependency which is required by libgdata dependency of YouTube plug-in and also by Dleyna plug-in, and which was removed during previous clean-up.

Also add dependencies for lua-factory plug-in which is enabled by default by master.

Partially fixes: #59792

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gnome3.grilo-plugins: add dependencies
121dce6 
Add libsoup dependency which is required by libgdata dependency of YouTube plug-in
and also by Dleyna plug-in, and which was removed during previous clean-up.

Also add dependencies for lua-factory plug-in which is enabled by default by master.

Partially fixes: NixOS#59792
@jtojnar jtojnar mentioned this pull request Apr 17, 2019
Closed
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 17, 2019
@worldofpeace
Copy link
Contributor

Perhaps a little comment about libgdata and libsoup together in buildInputs?

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 17, 2019

It is required by dleyna, opensubtitles and tmdb plug-ins, I do not think commenting declared dependencies is very useful.

@jtojnar jtojnar merged commit 356f3d9 into NixOS:master Apr 17, 2019
@jtojnar jtojnar deleted the grl-plugins-fix branch April 17, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grilo-plugins fails to build
3 participants
@jtojnar @worldofpeace @GrahamcOfBorg