Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-ethereum: 1.8.26 -> 1.8.27 #59794

Merged
merged 1 commit into from Apr 19, 2019
Merged

go-ethereum: 1.8.26 -> 1.8.27 #59794

merged 1 commit into from Apr 19, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 17, 2019

Motivation for this change

Update go-ethereum to the latest release.

https://github.com/ethereum/go-ethereum/releases/tag/v1.8.27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build go-ethereum

@adisbladis adisbladis self-assigned this Apr 17, 2019
@adisbladis
Copy link
Member

Looks like we need to apply ethereum/go-ethereum#19183 to fix the aarch64 build failure.

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 19, 2019 •
edited

Hi @adisbladis, thanks for the review.
I added a patch to apply ethereum/go-ethereum#19183 to fix the aarch64 build failure. (not sure if this works on aarch64)
Please review this PR again, if possible.

@adisbladis
Copy link
Member

@GrahamcOfBorg build go-ethereum

@adisbladis
Copy link
Member

I switched from putting the patch in the repository to using fetchpatch.
This is preferable for a number of reasons (clear patch origins, less churn, less repository growth).

@adisbladis adisbladis merged commit f4c69c0 into NixOS:master Apr 19, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 19, 2019

@adisbladis, thank you very much!

@adisbladis
Copy link
Member

adisbladis commented Apr 19, 2019 •
edited

Backported to 19.03: fe334ad

Thank you 👍

@xrelkd xrelkd deleted the update/go-ethereum branch April 19, 2019 09:48
@xrelkd xrelkd mentioned this pull request Jul 10, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adisbladis adisbladis

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @adisbladis @GrahamcOfBorg