Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtranslator: init at 3.32.0 #59746

Merged
merged 1 commit into from Apr 17, 2019
Merged

gtranslator: init at 3.32.0 #59746

merged 1 commit into from Apr 17, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 16, 2019 •
edited

Tool for translating Gettext files: https://gitlab.gnome.org/GNOME/gtranslator

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 16, 2019 •
edited

Has libglade in its Requries https://gitlab.gnome.org/GNOME/gtranslator/blob/3.32.0/data/gtranslator.pc.in#L8 ?

@jtojnar jtojnar force-pushed the gtranslator branch 2 times, most recently from 4d3f13d to 5afa700 Compare April 17, 2019 00:14
worldofpeace
worldofpeace approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at a .po

Screenshot from 2019-04-16 21 06 23

@jtojnar jtojnar added this to In Progress in GNOME Apr 17, 2019
@jtojnar jtojnar changed the base branch from master to staging April 17, 2019 20:38
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 17, 2019

And now CI does not like harfbuzz:

fixed-output derivation produced path '/nix/store/w3n916nvkx6zrqjmgy0mr6frm45sxsms-harfbuzz-2.4.0.tar.bz2' with sha256 hash '0vrkvdlmihdg62a4c6h5kx27khc33xmb95l50zgnwnavvpwyyw5l' instead of the expected hash '11a3kq3m6mgyjymgrmacr3h562qmmy2f6rc6wcj21mwv31j0avrk'

@jtojnar jtojnar merged commit 5b7f587 into NixOS:staging Apr 17, 2019
GNOME automation moved this from In Progress to Done Apr 17, 2019
@jtojnar jtojnar deleted the gtranslator branch April 17, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @worldofpeace @GrahamcOfBorg