nixos-infect: update channel to 18.09 #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asymmetric btw I see nixos-infect is only used with Digital Ocean, I don't have an account there. Does it still work and were you planning to update this for DO usage ? |
|
@AmineChikhaoui I was actually using this for the Hetzner Cloud backend, I haven't tried Digital Ocean yet, but I can tomorrow. Considering that this and this have been merged though, I think we could go with 19.03. |
|
Upstream switched to 18.09, so I guess we can go ahead with this? I can test 19.03 in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if 19.03 is a good idea given the issues with azure-mgmt-*, so sticking to 18.09.