Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner: 11.9.0 -> 11.9.2 #59768

Merged
merged 1 commit into from Apr 17, 2019
Merged

gitlab-runner: 11.9.0 -> 11.9.2 #59768

merged 1 commit into from Apr 17, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Apr 17, 2019

Fixes issues with git lfs.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
gitlab-runner: 11.9.0 -> 11.9.2
5def98b 
Fixes issues with git lfs.
@bachp
Copy link
Member Author

bachp commented Apr 17, 2019

@ryantm Is it possible to add this package to the semi automatic updates done by @r-ryantm? Usually the updates are trivial.

@globin globin merged commit b3d3b42 into NixOS:master Apr 17, 2019
@ryantm
Copy link
Member

ryantm commented Apr 17, 2019

@bachp Unfortunately, there are at least two reasons why the automated update fails for this package: One, the file contains multiple fetchers, and it is not smart enough to handle more than one. Two, it skips any package using buildGoPackage because it doesn't know how to update Go dependency files.

@bachp bachp deleted the gitlab-runner-11.9.2 branch April 18, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @ryantm @globin @GrahamcOfBorg