Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedup: init at 1.0 #59752

Merged
merged 2 commits into from Apr 28, 2019
Merged

dedup: init at 1.0 #59752

merged 2 commits into from Apr 28, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 17, 2019

Motivation for this change

Neat utility, 1.0 release.o

https://git.2f30.org/dedup/file/README.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg reviewed Apr 22, 2019
View reviewed changes
pkgs/tools/backup/dedup/default.nix

makeFlags = [
"CC:=$(CC)"
"PREFIX=${placeholder "out"}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of ${placeholder "out"} to $out?
(Not a request for change - I just don't know)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it because I know it'll work without worrying about quoting/escaping, especially as derivation/builder details change. At least it does in these simple cases, without requiring examination.

I'm not sure but it may not be appropriate when propagated through multiple scopes or certain things like passAsFile-- see #1846.

To me it feels more "direct" than a shell variable reference but I'm not sure how founded that is :).

@dtzWill dtzWill merged commit 6a73992 into NixOS:master Apr 28, 2019
@dtzWill dtzWill deleted the feature/dedup branch April 28, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endgame endgame endgame left review comments

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @endgame @JohnAZoidberg @GrahamcOfBorg