Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gsettings-desktop-schemas -> gsettings-desktop-schemas #59750

Merged
merged 1 commit into from Apr 17, 2019
Merged

gnome3.gsettings-desktop-schemas -> gsettings-desktop-schemas #59750

merged 1 commit into from Apr 17, 2019

Conversation

worldofpeace
Copy link
Contributor

gnome3.pomodoro is left out because I don't want to create a conflict.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace mentioned this pull request Apr 17, 2019
Merged
10 tasks
@worldofpeace
gnome3.gsettings-desktop-schemas -> gsettings-desktop-schemas
7abeda9 
gnome3.pomodoro is left out because I don't want to create a conflict.
@worldofpeace worldofpeace merged commit 21d45fe into NixOS:staging Apr 17, 2019
@worldofpeace worldofpeace deleted the gsettings-desktop-schemas branch April 17, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg