ejabberd: refactor module, add test #59731
Conversation
nixos/tests/ejabberd.nix
Outdated
| client = { nodes, pkgs, ... }: { | ||
| environment.systemPackages = let | ||
| sendMessage = pkgs.writeScriptBin "send-message" '' | ||
| #!/usr/bin/env python3 |
There was a problem hiding this comment.
| #!/usr/bin/env python3 | |
| #! ${(pkgs.python3.withPackages (ps: [ ps.sleekxmpp ])).interpreter} |
There was a problem hiding this comment.
This python script is lifted from the prosody test, so this should probably be fixed there, as well.
There was a problem hiding this comment.
It's not a necessity because both ways work fine. However, it would be nice to have a single file for the script.
There was a problem hiding this comment.
How about something like this?
|
Seems like |
ajs124
force-pushed
the
ejabberd_test
branch
2 times, most recently
from
802f40c
to
b8d4914
Compare
|
@GrahamcOfBorg test ejabberd |
|
How does that even happen? It worked on aarch64 but not x86_64? It works fine on my laptop and desktop. |
|
|
It's worth a try. I don't know if it makes a difference though, since it was already working for me on my machines. I mean, how and why would the mode of the directory influence the mode of its contents? |
|
It was just a guess based on the error message. With the current mode of the directory the file is accessible to more than just the owner. I'm also confused by this error because it worked on my machine as well. |
|
@ajs124 Fantastic work! 🎉 |
|
@GrahamcOfBorg test ejabberd |
Motivation for this change
I run ejabberd.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)