WIP: pkgsEmscripten: emscripten package set using cross toolchain #59784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the emscripten package set using the cross toolchain in a similar way as `pkgsCross`.
|
Unfortunately I'm getting an evaluation error. @dtzWill the structure is now roughly based on |
matthewbauer
requested review from
qknight,
matthewbauer and
dtzWill
and removed request for
qknight
GrahamcOfBorg
added
6.topic: stdenv
|
Looks okay. TBH I'd like everybody to use WASM/WASI, but I suppose it's nice to work with emscripten as it's more popular. emconfigure and emmake are mostly just a collection of hacks, so the likelihood of working with many packages out of the box is not great. |
| buildInputs = [ emscripten python ] ++ buildInputs; | ||
| nativeBuildInputs = [ emscripten python ] ++ nativeBuildInputs; | ||
| # name = "emscripten-${args.name}"; | ||
| buildInputs = (args.buildInputs or []) ++ [ emscripten python ]; |
| { | ||
| stdenv = super.stdenvAdapters.emscriptenAdapter super.stdenv; | ||
|
|
||
| json_c = super.json_c.overrideDerivation (old: { | ||
| nativeBuildInputs = [ autoreconfHook pkgconfig ]; | ||
| propagatedBuildInputs = [ zlib ]; | ||
| buildInputs = old.buildInputs ++ [ automake autoconf ]; |
|
It would also be good to update emscripten. I believe it's a little bit out of date. |
I agree with you. Right now, I just want to see if we can get pyodide running. |
|
I won't continue with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the emscripten package set using the cross toolchain in a similar
way as
pkgsMusl.Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)