Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegraf: 1.9.2 -> 1.10.2 #59689

Merged
merged 1 commit into from Apr 16, 2019
Merged

telegraf: 1.9.2 -> 1.10.2 #59689

merged 1 commit into from Apr 16, 2019

Conversation

kirelagin
Copy link
Member

Motivation for this change

Telegraf 1.10 has a new extremely useful option for the Prometheus exporter, export_timestamp.

I don’t know what the policy regarding the NixOS release branch is, but, I think, it would be nice to backport this to 19.03, if possible, since it is a non-major version increment, and, thus, is backward-compatible.

Things done

We use Telegraf with DogStatsD input and Prometheus output. At least in this configuration, everything is fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc maintainers @Mic92 @roblabla

Note: For some reason, I had to manually tweak the hash of
      ApplicationInsights-Go generated by dep2nix.
@Mic92
Copy link
Member

Mic92 commented Apr 16, 2019

@GrahamcOfBorg test telegraf

@Mic92 Mic92 merged commit f8564ae into NixOS:master Apr 16, 2019
@Mic92
Copy link
Member

Mic92 commented Apr 16, 2019

backport:

[detached HEAD dc11f48] telegraf: 1.9.2 -> 1.10.2
Author: Kirill Elagin kirelagin@gmail.com
Date: Tue Apr 16 09:11:30 2019 +0200
2 files changed, 87 insertions(+), 33 deletions(-)
rename pkgs/servers/monitoring/telegraf/{deps-1.9.2.nix => deps-1.10.2.nix} (92%)
Press Enter to continue
tig upstream/master 25.94s user 2.49s system 40% cpu 1:09.86 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants