Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exercism: 3.0.9 -> 3.0.11 #59688

Merged
merged 1 commit into from Apr 17, 2019
Merged

exercism: 3.0.9 -> 3.0.11 #59688

merged 1 commit into from Apr 17, 2019

Conversation

Siilwyn
Copy link
Contributor

@Siilwyn Siilwyn commented Apr 16, 2019

Motivation for this change

Update to last stable version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Not sure if and how deps.nix should be updated.

@marsam
Copy link
Contributor

marsam commented Apr 17, 2019

@GrahamcOfBorg build exercism

@marsam marsam merged commit c8184ec into NixOS:master Apr 17, 2019
@marsam
Copy link
Contributor

marsam commented Apr 17, 2019

Built and tested on NixOS and darwin.

Not sure if and how deps.nix should be updated.

lt's not necessary since the 'Gopkg' files didn't change between those releases
Thanks!

@Siilwyn
Copy link
Contributor Author

Siilwyn commented Apr 17, 2019 •
edited

@marsam thanks! Could you give an example of a 'Gopkg' file in the repository? Just to clear it up.

@marsam
Copy link
Contributor

marsam commented Apr 17, 2019

deps.nix lists the dependencies of a go project, and should be regenerated when these change.
In this case I was referring to the Gopkg.lock which exercism used to manage its dependencies, since it didn't change between those releases, it wasn't necessary to regenerate deps.nix

@Siilwyn
Copy link
Contributor Author

Siilwyn commented Apr 17, 2019

I see, thanks @marsam!
Got confused by the absence of the gopkg.lock file on the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Siilwyn @marsam @GrahamcOfBorg @Janik-Haag