Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.loo-py: init at 2017.2 #59657

Merged
merged 8 commits into from May 20, 2019
Merged

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Apr 16, 2019

Motivation for this change

This is a PR motivated by wanting to use the package loo.py. I have enabled as many tests as possible in all the packages. Serveral packages had to be built.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for packaging symengine on nixpkgs. Let me know if you have questions on packaging symengine and I'll be happy to answer. Btw, symengine 0.3 is 2 years old, but 0.4 is recent.

@costrouc
Copy link
Member Author

costrouc commented May 7, 2019

@isuruf latest packaged is now 0.4.0

@costrouc
Copy link
Member Author

costrouc commented May 7, 2019

nix review passes

Result of nix-review pr 59657 1

13 package were build:
  • python27Packages.cgen
  • python27Packages.genpy
  • python27Packages.islpy
  • python27Packages.loo-py
  • python27Packages.pymbolic
  • python27Packages.symengine
  • python37Packages.cgen
  • python37Packages.genpy
  • python37Packages.islpy
  • python37Packages.loo-py
  • python37Packages.pymbolic
  • python37Packages.symengine
  • symengine

symengine: init at 0.3.0
@costrouc
Copy link
Member Author

Ready for merge passes nix-review

Result of nix-review pr 59657 1

13 package were build:
  • python27Packages.cgen
  • python27Packages.genpy
  • python27Packages.islpy
  • python27Packages.loo-py
  • python27Packages.pymbolic
  • python27Packages.symengine
  • python37Packages.cgen
  • python37Packages.genpy
  • python37Packages.islpy
  • python37Packages.loo-py
  • python37Packages.pymbolic
  • python37Packages.symengine
  • symengine

@marsam marsam merged commit c5aef07 into NixOS:master May 20, 2019
@marsam
Copy link
Contributor

marsam commented May 20, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants