Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quazip: 0.7.3 -> 0.7.6 #59631

Merged
merged 2 commits into from Apr 24, 2019
Merged

quazip: 0.7.3 -> 0.7.6 #59631

merged 2 commits into from Apr 24, 2019

Conversation

bobvanderlinden
Copy link
Member

Motivation for this change

quazip has been moved from sourceforge to GitHub. This is why quazip wasn't picked up by automatic packages updates. See:

http://quazip.sourceforge.net/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [-] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@kierdavis kierdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested packages that depend on quazip:

  • nomacs - compiles, run, and can open a zip file containing a PNG image.
  • qmapshack - compiles and runs. I'm not familiar enough with this software to know what to do to exercise quazip.
  • teamspeak_client - compiles and runs. I'm not familiar enough with this software to know what to do to exercise quazip.

screencloud and tomahawk fail to evaluate due to broken packages. I think this is probably good to merge.

@c0bw3b c0bw3b merged commit 92e3089 into NixOS:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants