[websockets] Correct failure case #16354
Conversation
The test titled `002.html` includes a document which references an undefined property, `asset_equals`. Correcting this typo would allow tests to pass spuriously (that is: when the document is not discarded). Replace the assertion that was originally intended with `assert_unreached` so that user agents which execute this code path report a test failure. The test titled `001.html` also includes a misspelled reference, but it does not rely on the value. Remove the reference.
|
Reviewing more closely, it looks like the existing use of So I've added another commit to replace the existing |
|
One more bug: the child document uses the |
|
On further inspection, the expectation as written seems correct to me. The document should be salvageable because its only WebSocket has been closed, so being "made to disappear" during unload should have no effect. The property references continue to be incorrect, though, so the test cannot pass. I've filed a new pull request that only corrects the references: gh-20190. |
The test titled
002.htmlincludes a document which references anundefined property,
asset_equals. Correcting this typo would allowtests to pass spuriously (that is: when the document is not discarded).
Replace the assertion that was originally intended with
assert_unreachedso that user agents which execute this code pathreport a test failure.
The test titled
001.htmlalso includes a misspelled reference, but itdoes not rely on the value. Remove the reference.