Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycdio: fix build #59649

Closed
wants to merge 1 commit into from
Closed

pycdio: fix build #59649

wants to merge 1 commit into from

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Apr 15, 2019 •
edited

Motivation for this change

Fixes #58809

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jansol jansol requested a review from FRidh as a code owner April 15, 2019 23:03
tomberek
tomberek approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on Ubuntu. Did not test ripping a CD.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@rycee rycee self-assigned this Apr 19, 2019
@rycee
Copy link
Member

rycee commented Apr 19, 2019

Rebased to master in c48ad78.

@rycee rycee closed this Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@rycee rycee Awaiting requested review from rycee

Assignees

@rycee rycee

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pycdio fails to build with due to missing swig?
5 participants
@jansol @nixos-discourse @rycee @tomberek @GrahamcOfBorg