Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rambox: 0.6.3 -> 0.6.6 #59701

Merged
merged 1 commit into from Apr 19, 2019
Merged

rambox: 0.6.3 -> 0.6.6 #59701

merged 1 commit into from Apr 19, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 16, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 16, 2019

@GrahamcOfBorg build rambox

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 16, 2019
@Mic92
Copy link
Member Author

Mic92 commented Apr 16, 2019 •
edited

Currently it has an issue with whatsapp though: https://github.com/ramboxapp/community-edition/issues/2207#issuecomment-483605784

@mrVanDalo
Copy link
Contributor

Checked it (unsing nix-review pr 59701) on my 18.09 and it works.

@Ma27
Copy link
Member

Ma27 commented Apr 19, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 60f0a14 into NixOS:master Apr 19, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 19, 2019

@Mic92 thanks!

@Ma27
Copy link
Member

Ma27 commented Apr 19, 2019

Backported as 70546db.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 22, 2019
@Mic92 Mic92 deleted the rambox branch April 25, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @mrVanDalo @Ma27 @samueldr @GrahamcOfBorg