Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: fix darwin build #59795

Merged
merged 2 commits into from Jun 11, 2019
Merged

samba: fix darwin build #59795

merged 2 commits into from Jun 11, 2019

Conversation

jacereda
Copy link
Contributor

@jacereda jacereda commented Apr 17, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@strager
Copy link
Contributor

strager commented Apr 20, 2019 •
edited

It looks like samba is still broken on macOS (10.12) after this PR. The build does succeed now, but the binaries don't work:

$ nix-build -A samba .
/nix/store/1jaskd4fvvhdp9i9bxjkhvvz1n5jkfmy-samba-4.10.2

$ /nix/store/1jaskd4fvvhdp9i9bxjkhvvz1n5jkfmy-samba-4.10.2/bin/smbstatus
dyld: Library not loaded: /private/tmp/nix-build-samba-4.10.2.drv-0/samba-4.10.2/bin/default/librpc/libndr.dylib
  Referenced from: /nix/store/1jaskd4fvvhdp9i9bxjkhvvz1n5jkfmy-samba-4.10.2/bin/smbstatus
  Reason: image not found
zsh: abort      /nix/store/1jaskd4fvvhdp9i9bxjkhvvz1n5jkfmy-samba-4.10.2/bin/smbstatus

$ /nix/store/1jaskd4fvvhdp9i9bxjkhvvz1n5jkfmy-samba-4.10.2/bin/smbd
dyld: Library not loaded: /private/tmp/nix-build-samba-4.10.2.drv-0/samba-4.10.2/bin/default/lib/util/libsamba-util.dylib
  Referenced from: /nix/store/1jaskd4fvvhdp9i9bxjkhvvz1n5jkfmy-samba-4.10.2/bin/smbd
  Reason: image not found
zsh: abort      /nix/store/1jaskd4fvvhdp9i9bxjkhvvz1n5jkfmy-samba-4.10.2/bin/smbd

@jacereda
Copy link
Contributor Author

Waiting for an answer: #59925

@jacereda
Copy link
Contributor Author

In any case I would merge this, since it's preventing things like ffmpeg-full from building.

@matthewbauer matthewbauer merged commit 3db2fc5 into NixOS:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jacereda @strager @flokli @matthewbauer @GrahamcOfBorg