Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing client name closes construction windows #7479

Closed
ldpl opened this issue Apr 6, 2019 · 2 comments
Closed

Changing client name closes construction windows #7479

ldpl opened this issue Apr 6, 2019 · 2 comments
Milestone
1.10.0

Comments

@ldpl
Copy link
Contributor

ldpl commented Apr 6, 2019

Version of OpenTTD

1.9.0

Expected result

Not close. Because why?

Actual result

Closes construction windows and goal question windows (that are considered to be construction ones for some reason).

Steps to reproduce

join server
open some building tools
open console
type "name new_name"
@ldpl
Copy link
Contributor Author

ldpl commented Apr 6, 2019

ClientNetworkGameSocketHandler::Receive_SERVER_CLIENT_INFO calls SetLocalCompany which calls DeleteConstructionWindows

@bendevnull
Copy link

Is there a reason that this is unexpected behavior? It seems simple enough to fix.

Sorry, something went wrong.

@bendevnull bendevnull mentioned this issue Apr 18, 2019
Closed
@nielsmh nielsmh added this to the 1.10.0 milestone Sep 1, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Sep 8, 2019
@nielsmh
Fix OpenTTD#7479: Don't close construction windows when changing clie…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
027ff52 
…nt name
@nielsmh nielsmh mentioned this issue Sep 8, 2019
Merged
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Sep 16, 2019
@nielsmh
Fix OpenTTD#7479: Don't close construction windows when changing clie…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ad5d8b9 
…nt name
nielsmh added a commit that referenced this issue Sep 16, 2019
@nielsmh
Fix #7479: Don't close construction windows when changing client name
224bb10
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@nielsmh @douiwby
Fix OpenTTD#7479: Don't close construction windows when changing clie…
8efa8cc 
…nt name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
3 participants
@ldpl @nielsmh @bendevnull