Adjust test threshold for win10 #16370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 16, 2019
biquad-lowpass.html test is failing on windows 10 because it looks like the threshold is too tight. Relax the threshold a bit. Not sure why it should start failing now, but the change in threshold isn't huge (a bit larger than single-float epsilon). Bug: 952780 Change-Id: Ifcf1fb083d6a758e6c76ed5c251ae89e8371ac54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570325 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#651495}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1570325
branch
from
24b294a
to
5c7697f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
biquad-lowpass.html test is failing on windows 10 because it looks
like the threshold is too tight. Relax the threshold a bit.
Not sure why it should start failing now, but the change in threshold
isn't huge (a bit larger than single-float epsilon).
Bug: 952780
Change-Id: Ifcf1fb083d6a758e6c76ed5c251ae89e8371ac54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570325
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651495}