Fix flakiness in audioworklet-suspend.https.html #16368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 16, 2019
It is because the actual suspension takes time to stop the render loop completely. So the current time advances a little after the suspension and the assertion that compares two timestamps fails. This CL fixes the problem by: 1. Suspend the context immediately after its creation. 2. Cache timestamp A after the worklet module loading is completed. 3. Check timestamp B after 500ms. If the context is not suspended (which is the original bug), two timestamps A and B won't match. Bug: 953332 Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html Change-Id: I3fc4ccf78ec9c137128f8605d502692be303b02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570129 Reviewed-by: Raymond Toy <rtoy@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651437}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1570129
branch
from
a5af92b
to
5e578bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is because the actual suspension takes time to stop the render loop
completely. So the current time advances a little after the suspension
and the assertion that compares two timestamps fails.
This CL fixes the problem by:
(which is the original bug), two timestamps A and B won't match.
Bug: 953332
Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html
Change-Id: I3fc4ccf78ec9c137128f8605d502692be303b02e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570129
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651437}