Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop meta_filters support #16363

Merged
merged 1 commit into from Apr 16, 2019
Merged

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Apr 16, 2019

This exposes JSON objects to our public API, which should really be an implementation detail.

The original usage of this is already gone, as it turned out to be super fragile and got broken quite quickly. Loading items is now much quicker than it once was, and if we want to optimise the jstest case again we should probably do it with a more specific optimisation (probably adding a list of paths to the manifest with the flag?).

This exposes JSON objects to our public API, which should really
be an implementation detail.
@wpt-pr-bot wpt-pr-bot added infra manifest wptrunner The automated test runner, commonly called through ./wpt run labels Apr 16, 2019
@gsnedders gsnedders merged commit 0d32c19 into web-platform-tests:master Apr 16, 2019
@gsnedders gsnedders deleted the meta_filter branch April 16, 2019 15:45
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
This exposes JSON objects to our public API, which should really
be an implementation detail.

It's also nowadays unused, as it (unsurprisingly) turned out to be
super fragile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra manifest wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants