Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubootRock64, ubootRockPro64: make compatible with latest dtc #59804

Merged
merged 1 commit into from May 2, 2019
Merged

ubootRock64, ubootRockPro64: make compatible with latest dtc #59804

merged 1 commit into from May 2, 2019

Conversation

lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Apr 18, 2019 •
edited

Motivation for this change

The update to U-Boot 1.5.0 dropped the setup.py patch, but it is still needed by dtc 1.4.5, used to build ubootRock64.

Things done

Add the patch to the dtc 1.4.5 override.

cc @dezgeg

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
Copy link
Contributor Author

Instead of fixing the older dtc version, I changed this PR to apply a patch to U-Boot to make it compatible with the latest dtc. This builds correctly, but I have not verified that it actually boots.

@lopsided98 lopsided98 changed the title ubootRock64: fix build by adding patch to dtc 1.4.5 ubootRock64, ubootRockPro64: make compatible with latest dtc Apr 20, 2019
thefloweringash
thefloweringash approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@thefloweringash thefloweringash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested booting this on my Rock64. Did not check serial output.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@samueldr samueldr merged commit b726784 into NixOS:master May 2, 2019
@lopsided98 lopsided98 deleted the uboot-rock64-fix branch May 6, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefloweringash thefloweringash thefloweringash approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @thefloweringash @samueldr @GrahamcOfBorg