Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] gnome3.tracker: 2.1.6 -> 2.1.8 #59788

Merged
merged 1 commit into from Apr 18, 2019
Merged

[19.03] gnome3.tracker: 2.1.6 -> 2.1.8 #59788

merged 1 commit into from Apr 18, 2019

Conversation

worldofpeace
Copy link
Contributor

Fixes #59772

Also fix path to gdbus in the autostart.

https://gitlab.gnome.org/GNOME/tracker/blob/2.1.8/NEWS

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 17, 2019
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 17, 2019
@worldofpeace worldofpeace removed the 8.has: port to stable A PR already has a backport to the stable release. label Apr 17, 2019
@worldofpeace
Copy link
Contributor Author

cc @arianvp

@arianvp
Copy link
Member

arianvp commented Apr 17, 2019

In theory looks good to me. though I haven't yet tested the patch... (I'm not sure how to)

@arianvp arianvp mentioned this pull request Apr 17, 2019
Closed
@arianvp
Copy link
Member

arianvp commented Apr 18, 2019 •
edited

@worldofpeace I built and tested it and the problem has indeed vanished. Tracker is happily indexing my files at the moment. However, there are definitely still a lot of things broken. But LGTM this particular PR.

There do still seem to be some issues with some certain services in Gnome. But lets open new issues for those. Especially the Characters Service still crashes though I'm not sure what its purpose is

Apr 18 10:51:53 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Successfully activated service 'org.gnome.Calculator.SearchProvider'
Apr 18 10:51:53 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Successfully activated service 'org.gnome.clocks'
Apr 18 10:51:53 t430s org.gnome.Chara[3564]: JS ERROR: Error: Requiring GjsPrivate, version none: Typelib file for namespace 'Gtk', version '3.0' not found
                                             @resource:///org/gnome/gjs/modules/overrides/Gio.js:22:5
                                             @resource:///org/gnome/gjs/modules/package.js:32:7
                                             @/nix/store/3ng1zq5766agr78gnjd9fmfigrcaa23l-gnome-characters-3.30.0/share/org.gnome.Characters/org.gnome.Characters.BackgroundService:2:1
Apr 18 10:51:53 t430s org.gnome.Characters.BackgroundService[2030]: Script /nix/store/3ng1zq5766agr78gnjd9fmfigrcaa23l-gnome-characters-3.30.0/share/org.gnome.Characters/org.gnome.Characters.BackgroundService threw an exception
Apr 18 10:51:53 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Activated service 'org.gnome.Characters.BackgroundService' failed: Process org.gnome.Characters.BackgroundService exited with status 1
Apr 18 10:51:53 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Activating service name='org.gnome.Characters.BackgroundService' requested by ':1.7' (uid=1000 pid=2100 comm="/nix/store/a1qmiazqw8a7qpsggn6i73pqh7hc83bd-gnome-")
Apr 18 10:51:53 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Successfully activated service 'org.gnome.Photos'
Apr 18 10:51:53 t430s org.gnome.Chara[3601]: JS ERROR: Error: Requiring GjsPrivate, version none: Typelib file for namespace 'Gtk', version '3.0' not found
                                             @resource:///org/gnome/gjs/modules/overrides/Gio.js:22:5
                                             @resource:///org/gnome/gjs/modules/package.js:32:7
                                             @/nix/store/3ng1zq5766agr78gnjd9fmfigrcaa23l-gnome-characters-3.30.0/share/org.gnome.Characters/org.gnome.Characters.BackgroundService:2:1
Apr 18 10:51:53 t430s org.gnome.Characters.BackgroundService[2030]: Script /nix/store/3ng1zq5766agr78gnjd9fmfigrcaa23l-gnome-characters-3.30.0/share/org.gnome.Characters/org.gnome.Characters.BackgroundService threw an exception
Apr 18 10:51:54 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Activated service 'org.gnome.Characters.BackgroundService' failed: Process org.gnome.Characters.BackgroundService exited with status 1
Apr 18 10:51:54 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Successfully activated service 'org.gnome.Contacts.SearchProvider'
Apr 18 10:51:54 t430s gnome-terminal-server[3565]: Display does not support owner-change; copy/paste will be broken!
Apr 18 10:51:54 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Successfully activated service 'org.gnome.Terminal'

Also, Gnome Music Instantly crashes when you try to play any song after a second of audio

Apr 18 10:55:44 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Activating service name='com.intel.dleyna-server' requested by ':1.171' (uid=1000 pid=4338 comm="/nix/store/0n8slcq8p5x31kc9hncabsqq9y3fpkzp-python")
Apr 18 10:55:44 t430s dleyna-server-service[4359]: dLeyna core version 0.6.0
Apr 18 10:55:44 t430s dleyna-server-service[4359]: dleyna-server-service version 0.6.0
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Load file [(null)]
Apr 18 10:55:44 t430s dleyna-server-service[4359]: [General settings]
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Never Quit: F
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Connector Name: dbus
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Port: 0
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Push host port: 0
Apr 18 10:55:44 t430s dleyna-server-service[4359]: [Logging settings]
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Log Type : 0
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Log Level: 0x13
Apr 18 10:55:44 t430s dleyna-server-service[4359]: [Network filtering settings]
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Enabled : F
Apr 18 10:55:44 t430s dleyna-server-service[4359]: Entries: (null)
Apr 18 10:55:44 t430s dbus-daemon[2030]: [session uid=1000 pid=2030] Successfully activated service 'com.intel.dleyna-server'
Apr 18 10:55:44 t430s dleyna-renderer-service[4337]: dLeyna: Exit
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]: Traceback (most recent call last):
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]:   File "/nix/store/dy2v5r08x2cwz4ai69sv6n8dyp33921b-gnome-music-3.30.2/lib/python3.7/site-packages/gnomemusic/widgets/smoothscale.py", line 110, in _on_state_change
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]:     self._update_timeout()
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]:   File "/nix/store/dy2v5r08x2cwz4ai69sv6n8dyp33921b-gnome-music-3.30.2/lib/python3.7/site-packages/gnomemusic/widgets/smoothscale.py", line 199, in _update_timeout
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]:     timeout_period, self._update_position_callback)
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]:   File "/nix/store/9jyqlkf8q1disirs79pqh5pwcdxhmd9f-python3.7-pygobject-3.30.4/lib/python3.7/site-packages/gi/overrides/GLib.py", line 610, in timeout_add
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]:     return GLib.timeout_add(priority, interval, function, *user_data)
Apr 18 10:55:47 t430s org.gnome.Music.desktop[2100]: OverflowError: -15734 not in range 0 to 4294967295
Apr 18 10:55:49 t430s dleyna-server-service[4359]: dLeyna: Exit

@worldofpeace
Copy link
Contributor Author

@worldofpeace I built and tested it and the problem has indeed vanished. Tracker is happily indexing my files at the moment. However, there are definitely still a lot of things broken. But LGTM this particular PR.

Thanks a lot for testing 👍

There do still seem to be some issues with some certain services in Gnome. But lets open new issues for those. Especially the Characters Service still crashes though I'm not sure what its purpose is

I've never used it so it's on my list to check if that issue is present on master as well.

Also, Gnome Music Instantly crashes when you try to play any song after a second of audio

The issue with gnome-music also seems to be an upstream issue

@worldofpeace worldofpeace merged commit 80e68d5 into NixOS:release-19.03 Apr 18, 2019
@worldofpeace worldofpeace deleted the stable-tracker-update branch April 18, 2019 09:08
@arianvp
Copy link
Member

arianvp commented Apr 18, 2019

@worldofpeace yes and there is a patch for it in version 3.32.1 https://gitlab.gnome.org/GNOME/gnome-music/commit/1d642c0f7a5bd7ab544b3bee212f92a73ba5d5cf

@jtojnar
Copy link
Contributor

jtojnar commented Apr 18, 2019

Characters issue is caused by the same thing #31168 is – the entry point is in /share, so if we wrap the /bin executable, it will not apply to the service or search provider, and what is more, it will break the gresource lookup (as described in the issue, scripts on Linux do not respect -a argument of exec). For that reason we would also need to change the JS file like in jtojnar@910d8e4 (the files were renamed, but it should work with minor tweaks), or do what Polari does: https://gitlab.gnome.org/GNOME/gnome-characters/issues/29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @arianvp @jtojnar @GrahamcOfBorg