Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joker: 0.10.1 -> 0.12.2 #59737

Merged
merged 1 commit into from Apr 19, 2019
Merged

joker: 0.10.1 -> 0.12.2 #59737

merged 1 commit into from Apr 19, 2019

Conversation

ernestas
Copy link
Contributor

@ernestas ernestas commented Apr 16, 2019 •
edited

Motivation for this change

Updating version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 18, 2019

@GrahamcOfBorg build joker

@c00w
Copy link
Contributor

c00w commented Apr 19, 2019 •
edited

Looks good - Binary seems to work and looks like it has no downstream dependencies. Commit looks good, ofBorg succeeded, and nix-review produced a valid binary.

[X] reviewed the diff and commit messages
[X] made sure ofBorg build succeeded for all applicable platforms
[X] run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)

@c0bw3b c0bw3b merged commit 6d0fc1c into NixOS:master Apr 19, 2019
@andrestylianos andrestylianos mentioned this pull request Jun 9, 2019
Closed
@ernestas ernestas deleted the joker-0.12.2 branch July 29, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ernestas @c0bw3b @c00w @GrahamcOfBorg @Janik-Haag