Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tentative from table test name #16367

Merged
merged 2 commits into from Apr 16, 2019
Merged

Remove tentative from table test name #16367

merged 2 commits into from Apr 16, 2019

Conversation

davidsgrogan
Copy link
Member

Remove .tentative because the behavior was already in the spec. Also add some metadata.

FremyCompany
FremyCompany approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@FremyCompany FremyCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the code, then ran the testcase to confirm my assumptions, and this looks good to me.

@FremyCompany FremyCompany merged commit 90b70a9 into web-platform-tests:master Apr 16, 2019
@davidsgrogan davidsgrogan deleted the table-bounding-box branch April 16, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FremyCompany FremyCompany FremyCompany approved these changes

@dbaron dbaron Awaiting requested review from dbaron

@gregwhitworth gregwhitworth Awaiting requested review from gregwhitworth

@rachelandrew rachelandrew Awaiting requested review from rachelandrew

Assignees

@FremyCompany FremyCompany

Labels
css-tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidsgrogan @FremyCompany @wpt-pr-bot