Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magnetico: init package and service #64738

Merged
merged 3 commits into from Aug 28, 2019
Merged

magnetico: init package and service #64738

merged 3 commits into from Aug 28, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jul 14, 2019 •
edited

Motivation for this change

Wanted to self-host a DHT crawler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have tested basically everything. the crawler works, the web ui works, also authentication.

@rnhmjoj rnhmjoj requested a review from infinisil as a code owner July 14, 2019 18:44
@ofborg ofborg bot requested a review from kalbasit July 14, 2019 18:58
kalbasit
kalbasit reviewed Jul 15, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the Go package.

pkgs/applications/networking/p2p/magnetico/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/p2p/magnetico/default.nix Outdated Show resolved Hide resolved
kalbasit
kalbasit approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the Go package only. I have not reviewed the NixOS module.

@kalbasit
Copy link
Member

@GrahamcOfBorg build magnetico

@ofborg ofborg bot requested a review from kalbasit July 15, 2019 15:06
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 20, 2019

I disabled the build on darwin, since ofBorg says the build is failing.

tilpner
tilpner reviewed Aug 26, 2019
View reviewed changes
nixos/modules/services/networking/magnetico.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/magnetico.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/magnetico.nix Outdated

web.port = mkOption {
type = types.port;
default = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem sensible. Wouldn't this cause an arbitrary free port to be selected every time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, it's what the software does by default. Do you think I should pick an arbitrary port?

nixos/modules/services/networking/magnetico.nix Outdated Show resolved Hide resolved
infinisil
infinisil requested changes Aug 27, 2019
View reviewed changes
nixos/modules/services/networking/magnetico.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/magnetico.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/magnetico.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/magnetico.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/p2p/magnetico/default.nix Show resolved Hide resolved
pkgs/applications/networking/p2p/magnetico/default.nix Show resolved Hide resolved
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 28, 2019

I added a small test.

infinisil
infinisil requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this thing, this LGTM

nixos/modules/services/torrent/magnetico.nix Outdated Show resolved Hide resolved
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 28, 2019

Should be ready.

@infinisil infinisil merged commit 6233291 into NixOS:master Aug 28, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 28, 2019

Thank you all for the review.

@rnhmjoj rnhmjoj deleted the magnetico branch September 14, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilpner tilpner tilpner left review comments

@infinisil infinisil infinisil approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @kalbasit @tilpner @infinisil