IPXE EFI netboot fix #64815
Merged
IPXE EFI netboot fix #64815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to build several targets with conflicting names. UEFI version of USB image is now built, and so is option ROM.
imgtrust is needed to run netboot.xyz scripts. ping is useful for testing network settings. Also add HTTP option for clarity (it's already being built).
Needed for iPXE on UEFI, see http://forum.ipxe.org/archive/index.php/thread-7589.html
Needed for UEFI PXE netboot testing.
Generalize netboot testing and add tests for UEFI PXE netboot.
|
@GrahamcOfBorg test boot.uefiNetboot boot.biosNetboot |
grahamc
reviewed
Jul 15, 2019
| @@ -84,7 +84,7 @@ with lib; | |||
|
|
|||
| system.build.netbootIpxeScript = pkgs.writeTextDir "netboot.ipxe" '' | |||
| #!ipxe | |||
| kernel ${pkgs.stdenv.hostPlatform.platform.kernelTarget} init=${config.system.build.toplevel}/init ${toString config.boot.kernelParams} | |||
| kernel ${pkgs.stdenv.hostPlatform.platform.kernelTarget} init=${config.system.build.toplevel}/init initrd=initrd ${toString config.boot.kernelParams} | |||
|
Offtopic: maybe we should mention https://netboot.xyz and their NixOS support on our download page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Boot NixOS in EFI mode using iPXE. Also add actual tests for this.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)