Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.knack: 0.6.2 -> 0.6.3 #64886

Merged
merged 1 commit into from Jul 16, 2019
Merged

pythonPackages.knack: 0.6.2 -> 0.6.3 #64886

merged 1 commit into from Jul 16, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 16, 2019 •
edited

Motivation for this change

Finally figured out why /home-shelter was coming up in tests after more time rummaging around the builders. Decided to fix the tests after i saw #64882

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
nix-review wip
...
[5 built, 0.0 MiB DL]
4 package were build:
python27Packages.azure-cli-core python27Packages.knack python37Packages.azure-cli-core python37Packages.knack

nix path-info -Sh ./result
/nix/store/z9jczg3mn1j8c8sqvn0mqsm232qg2633-python3.7-knack-0.6.2	 129.4M
nix path-info -Sh ./results/python37Packages.knack
/nix/store/93p7bxdh25zm8jddqi36l27l313i4i21-python3.7-knack-0.6.3	 129.5M

@jonringer jonringer requested a review from FRidh as a code owner July 16, 2019 09:40
@ryantm ryantm merged commit 184694b into NixOS:master Jul 16, 2019
@jonringer jonringer deleted the knack-fix-test branch December 1, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @ryantm