Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/borgbackup: generate wrappers per job for easy borg access #64888

Closed
wants to merge 1 commit into from
Closed

nixos/borgbackup: generate wrappers per job for easy borg access #64888

wants to merge 1 commit into from

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

Currently, if you want to execute borg commands on a setup borg job manually, you have to cobble together the arguments from your config and the borg module source. This PR installs wrappers for each of your jobs, that you can access with borg-job-NAME.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP
Copy link
Contributor Author

cc: @dotlambda

@bjornfor
Copy link
Contributor

This is a great idea!

@bjornfor
Copy link
Contributor

Can you add the motivation behind this change in the commit message? (Tip: if you start out with the text in the commit message, you'll get the PR message already "filled in" by github. It doesn't work the other way around.)

@danbst danbst closed this in 470c8a2 Dec 26, 2019
@yorickvP yorickvP deleted the borgbackup-wrapper branch January 29, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yorickvP @bjornfor