Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exa: 0.8.0 -> 0.9.0 #64773

Merged
merged 1 commit into from Jul 15, 2019
Merged

exa: 0.8.0 -> 0.9.0 #64773

merged 1 commit into from Jul 15, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Jul 15, 2019

Motivation for this change

https://github.com/ogham/exa/releases/tag/v0.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (with sandbox)
    • macOS (without sandbox)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @ehegnes

Also added myself as a maintainer.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64773 passes on NixOS
diff LGTM
binary works
leaf package

Thanks @lilyball :)

@worldofpeace
Copy link
Contributor

Finally a release, it's been almost forever since the last one 😄

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me also.

@worldofpeace worldofpeace merged commit 6dcfdb4 into NixOS:master Jul 15, 2019
@killercup killercup mentioned this pull request Jul 15, 2019
10 tasks
@lilyball lilyball deleted the exa branch July 15, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants