Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memo: 0.6 -> 0.8 #64676

Merged
merged 1 commit into from Jul 13, 2019
Merged

memo: 0.6 -> 0.8 #64676

merged 1 commit into from Jul 13, 2019

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

kalbasit commented Jul 12, 2019 •
edited

@mrVanDalo your commit and PR title do not follow the https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md guide.

@mrVanDalo mrVanDalo changed the title memo: version bump memo: 0.6 -> 0.8 Jul 12, 2019
@mrVanDalo
Copy link
Contributor Author

mrVanDalo commented Jul 12, 2019 •
edited

@kalbasit true, fixed now.

@kalbasit
Copy link
Member

@GrahamcOfBorg build memo

@kalbasit kalbasit merged commit 6cc4c0a into NixOS:master Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrVanDalo @kalbasit