[LayoutNG] Consider nodes with only floats/OOFs as block-level. #17808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 12, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1696345
branch
2 times, most recently
from
e75fa48
to
829229e
Compare
Legacy/WebKit have a "interesting" behaviour for empty-inlines in that they determine the static position of any (inline-level) OOF-positioned nodes as if they were in the block-level context. Other browsers do the following (testcase): https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=7055 FF - all inline-level Safari/Legacy - all block-level Edge - block-level for default/block-level NG (prior to this change) - inline-level for default/inline-level. This change makes the "default" e.g. a node with just floats/OOFs as block-level to pick up this static position behaviour. This matches the EdgeHTML behaviour. Bug: 980908 Change-Id: Ifb92bf7e34ada669fa16a1ee5f9e9edaf4546768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696345 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#677105}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1696345
branch
from
829229e
to
8d3716b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy/WebKit have a "interesting" behaviour for empty-inlines in that
they determine the static position of any (inline-level) OOF-positioned
nodes as if they were in the block-level context.
Other browsers do the following (testcase):
https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=7055
FF - all inline-level
Safari/Legacy - all block-level
Edge - block-level for default/block-level
NG (prior to this change) - inline-level for default/inline-level.
This change makes the "default" e.g. a node with just floats/OOFs as
block-level to pick up this static position behaviour.
This matches the EdgeHTML behaviour.
Bug: 980908
Change-Id: Ifb92bf7e34ada669fa16a1ee5f9e9edaf4546768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696345
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677105}