Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx-qt5: 1.2.1 -> 1.2.3 #64674

Merged
merged 1 commit into from Jul 23, 2019
Merged

fcitx-qt5: 1.2.1 -> 1.2.3 #64674

merged 1 commit into from Jul 23, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 12, 2019

Motivation for this change

Update fcitx-qt5 to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 23, 2019 •
edited

changes https://gitlab.com/fcitx/fcitx-qt5/compare/1.2.1...1.2.3

@GrahamcOfBorg build libsForQt5.fcitx-qt5

@worldofpeace worldofpeace changed the base branch from staging to master July 23, 2019 08:22
@ttuegel
Copy link
Member

ttuegel commented Jul 23, 2019

Does this need to go into staging rather than master?

@worldofpeace
Copy link
Contributor

@ttuegel It was targeted for staging originally, but only one thing depends on this package.

Changing the base branch brought in those commits.

@worldofpeace worldofpeace merged commit f981d41 into NixOS:master Jul 23, 2019
@xrelkd xrelkd deleted the update/fcitx-qt5 branch July 24, 2019 02:31
@teto
Copy link
Member

teto commented Jul 29, 2019

this fails on nixos-unstable with #65547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xrelkd @worldofpeace @ttuegel @teto @FRidh