Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ee15538cf01c
Choose a base ref
...
head repository: m-labs/nmigen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b963449b41dd
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 14, 2019

  1. build.run: Ensure batch script returns proper error code.

    cr1901 authored and whitequark committed Jul 14, 2019
    Copy the full SHA
    b963449 View commit details
Showing with 7 additions and 1 deletion.
  1. +7 −1 nmigen/build/run.py
8 changes: 7 additions & 1 deletion nmigen/build/run.py
Original file line number Diff line number Diff line change
@@ -71,7 +71,13 @@ def execute_local(self, root="build", run_script=True):

if run_script:
if sys.platform.startswith("win32"):
subprocess.check_call(["cmd", "/c", "{}.bat".format(self.script)])
# Without "call", "cmd /c {}.bat" will return 0.
# See https://stackoverflow.com/a/30736987 for a detailed
# explanation of why, including disassembly/decompilation
# of relevant code in cmd.exe.
# Running the script manually from a command prompt is
# unaffected- i.e. "call" is not required.
subprocess.check_call(["cmd", "/c", "call {}.bat".format(self.script)])
else:
subprocess.check_call(["sh", "{}.sh".format(self.script)])