Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

victor-mono: init at 1.2.1 #64694

Merged
merged 1 commit into from Jul 13, 2019
Merged

victor-mono: init at 1.2.1 #64694

merged 1 commit into from Jul 13, 2019

Conversation

jpotier
Copy link
Contributor

@jpotier jpotier commented Jul 13, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alexarice
alexarice reviewed Jul 13, 2019
View reviewed changes
pkgs/data/fonts/victor-mono/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/victor-mono/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/victor-mono/default.nix Show resolved Hide resolved
alexarice
alexarice approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds with nix-review, haven't tested if any of the fonts actually work

pkgs/data/fonts/victor-mono/default.nix Show resolved Hide resolved
@jpotier
Copy link
Contributor Author

jpotier commented Jul 13, 2019

image

Small sample of the actual font in use.

jonringer
jonringer approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64694 passes on NixOS
diff LGTM
tree install structure looks good

$ nix path-info -Sh ./results/victor-mono
/nix/store/bq2achgag19da6y7lgdadycx55bfxr5v-victor-mono-1.2.1      1.1M

@worldofpeace worldofpeace merged commit 1ab8c3e into NixOS:master Jul 13, 2019
@jpotier jpotier deleted the victor-mono branch July 13, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpotier @jonringer @alexarice @worldofpeace