Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytcc: enable tests #64777

Merged
merged 1 commit into from Jul 18, 2019
Merged

ytcc: enable tests #64777

merged 1 commit into from Jul 18, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Was ripgrepping through nixpkgs and noticed it had tests disabled, enabled to verify it's not going to be broken by upstream dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/hhjr5fk9zbwwpfzjdwzrvk2afps43sjj-ytcc-1.8.1   244.1M
$ nix-review wip
...
[1 built, 0.0 MiB DL]
1 package were build:
ytcc

@srhb srhb merged commit f4ed4b8 into NixOS:master Jul 18, 2019
@jonringer jonringer deleted the ytcc-enable-tests branch December 1, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants