Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: update #64696

Merged
merged 1 commit into from Jul 13, 2019
Merged

vimPlugins: update #64696

merged 1 commit into from Jul 13, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jul 13, 2019 •
edited

Motivation for this change

Regular update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau merged commit 23a51a6 into NixOS:master Jul 13, 2019
@timokau timokau deleted the vimPlugins-2019-07-13 branch July 13, 2019 10:12
jonringer
jonringer approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64696 passes on NixOS
diff LGTM

not sure how to really test vim plugins :(

@timokau
Copy link
Member Author

timokau commented Jul 13, 2019

Thanks!

not sure how to really test vim plugins :(

Since they are all updated at once, its pretty much infeasible to test every one of them. Luckily there usually isn't any compilation involved and they are developed with "latest master is always shippable" in mind, so breakage is uncommon. What I usually do is nix-review and rebuilding my own system with the branch.

Would be nice to have some automated testing for vim packages, but that would probably be a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @jonringer