Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wmc-mpris: init at 2019-04-12 #64891

Merged
merged 1 commit into from Jul 27, 2019
Merged

wmc-mpris: init at 2019-04-12 #64891

merged 1 commit into from Jul 27, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

See web extension: https://addons.mozilla.org/en-US/firefox/addon/web-media-controller/ .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the commit message to be
wmc-mpris: init at 2019-04-12

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build wmc-mpris

@doronbehar doronbehar changed the title wmc-mpris: init at git version wmc-mpris: init at 2019-04-12 Jul 23, 2019
@doronbehar doronbehar mentioned this pull request Jul 24, 2019
Merged
@worldofpeace
Copy link
Contributor

@doronbehar
So you are actually a team?

No Nonbinary.

https://www.dictionary.com/browse/nonbinary 3 and 4

@doronbehar doronbehar force-pushed the package-wmc-mpris branch 2 times, most recently from 7e49b84 to 3e3deae Compare July 27, 2019 13:52
@worldofpeace worldofpeace merged commit 383da6b into NixOS:master Jul 27, 2019
@worldofpeace
Copy link
Contributor

Thanks for working on this @doronbehar ✨

@doronbehar
Copy link
Contributor Author

My pleasure, without you it wasn't possible 🍻.

@doronbehar doronbehar deleted the package-wmc-mpris branch August 22, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@f1u77y f1u77y f1u77y left review comments

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @worldofpeace @JohnAZoidberg @f1u77y