Update interfaces/push-api.idl #17826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Jul 14, 2019
|
Test needs updating to fix one regression. |
|
This change looks wrong; THe interface isn't deleted. |
|
At a guess based on timing and the interfaces that reffy-reports has dropped, this change caused it: Perhaps the default syntax isn't valid IDL according to reffy-reports? @tidoust - any idea? |
autofoolip
force-pushed
the
reffy-reports/push-api
branch
from
3b811cf
to
a8ad8d0
Compare
|
Filed w3c/webref#34 |
autofoolip
force-pushed
the
reffy-reports/push-api
branch
from
a8ad8d0
to
8402ea8
Compare
foolip
approved these changes
Jul 30, 2019
|
The changes look sensible now, and no change in results (checked Firefox). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by a bot.
Before merging, please check that any tests that depend on the updated IDL files still work.
If additional changes are needed, please manually create another PR based on this one.
See the README for how the IDL files in this directory are used.
Source: https://github.com/tidoust/reffy-reports/blob/52f31b9/whatwg/idl/push-api.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/563479802