[Gecko Bug 1562086] Add percentage for opacity (i.e. <alpha-value>). #17817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following properties accept <alpha-value> [1], which is "<number> | <percentage>", so we update the parser, spec links, and their web-platform-tests. 1. opacity 2. flood-opacity 3. fill-opacity 4. stroke-opacity 5. stop-opacity 6. -moz-window-opacity Besides, shape-image-threshold [2] still only accepts <number>, so we need to support a different version of `Opacity::parse()`. [1] https://drafts.csswg.org/css-color/#typedef-alpha-value [2] https://drafts.csswg.org/css-shapes/#shape-image-threshold-property Differential Revision: https://phabricator.services.mozilla.com/D37493 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562086 gecko-commit: abe58536c427f4a810df1274a6069b8a4832bcf2 gecko-integration-branch: autoland gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following properties accept [1], which is
" | ", so we update the parser, spec links, and
their web-platform-tests.
Besides, shape-image-threshold [2] still only accepts , so we need
to support a different version of
Opacity::parse().[1] https://drafts.csswg.org/css-color/#typedef-alpha-value
[2] https://drafts.csswg.org/css-shapes/#shape-image-threshold-property
Differential Revision: https://phabricator.services.mozilla.com/D37493
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562086
gecko-commit: abe58536c427f4a810df1274a6069b8a4832bcf2
gecko-integration-branch: autoland
gecko-reviewers: emilio